Review Request 115536: Add window thumbnail to taskmanager

[Mark Gaiser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115536/#review49216
-----------------------------------------------------------


It might be best to replace all "_s * 2" with "units.largeSpacing" since that's what it is anyway.
The hardcoded width and height (200 and 150) seem a bit hard.. Can you make that dynamic?

Other then those two points it looks OK to me.

- Mark Gaiser


On Feb. 7, 2014, 12:44 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115536/
> -----------------------------------------------------------
> 
> (Updated Feb. 7, 2014, 12:44 p.m.)
> 
> 
> Review request for Plasma and Eike Hein.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> Add window thumbnail to taskmanager
> 
> It forks the DefaultToolTip qml and adds the window thumbnails.
> 
> It's not yet working perfectly and I would like to have our QML
> experts have a look at it and give it a try.
> 
> 
> Diffs
> -----
> 
>   plasma/desktop/applets/taskmanager/package/contents/ui/Task.qml 11e80db26c6de14a8a1f0c0fedfd48dc1ffaef5e 
>   plasma/desktop/applets/taskmanager/package/contents/ui/ToolTipDelegate.qml PRE-CREATION 
>   plasma/desktop/applets/taskmanager/package/contents/ui/main.qml d590ec904d91beb1f3063b14d4e98596882ea365 
> 
> Diff: https://git.reviewboard.kde.org/r/115536/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140207/96ac1f7e/attachment.html>