Review Request 115536: Add window thumbnail to taskmanager

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115536/#review49180
-----------------------------------------------------------


for me +1 apart following small issue


plasma/desktop/applets/taskmanager/package/contents/ui/Task.qml
<https://git.reviewboard.kde.org/r/115536/#comment34751>

    I think it should be possible to have only one instance of ToolTip (i would call it ToolTipDelegate) in the root item, and then recycling it for every one, having only tooltipareas duplicated. the difference in memory would be quite noticeable


- Marco Martin


On Feb. 7, 2014, 12:02 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115536/
> -----------------------------------------------------------
> 
> (Updated Feb. 7, 2014, 12:02 p.m.)
> 
> 
> Review request for Plasma and Eike Hein.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> Add window thumbnail to taskmanager
> 
> It forks the DefaultToolTip qml and adds the window thumbnails.
> 
> It's not yet working perfectly and I would like to have our QML
> experts have a look at it and give it a try.
> 
> 
> Diffs
> -----
> 
>   plasma/desktop/applets/taskmanager/package/contents/ui/Task.qml 11e80db26c6de14a8a1f0c0fedfd48dc1ffaef5e 
>   plasma/desktop/applets/taskmanager/package/contents/ui/ToolTip.qml PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/115536/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140207/c3075f21/attachment.html>