Review Request 115500: Set minimumWidth of button to actually fit the text

David Edmundson david at davidedmundson.co.uk
Wed Feb 5 15:44:40 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115500/
-----------------------------------------------------------

Review request for Plasma.


Repository: plasma-framework


Description
-------

Set minimumWidth of button to actually show the text

The minimumWidth of a plasma button is based on the paintedWidth
of the text item. There is no way to work out the correct width it
should be if we set the text to elide.
(except for the hack of using a hidden fake text item)

We should always fit contents. This won't cause any problems unless a
developer has a broken layout, at which point that should be fixed


Diffs
-----

  src/declarativeimports/plasmacomponents/qml/Button.qml 03fa42c 

Diff: https://git.reviewboard.kde.org/r/115500/diff/


Testing
-------


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140205/3feda281/attachment.html>


More information about the Plasma-devel mailing list