Review Request 115475: Split KRunner out of plasma-framework

David Edmundson david at davidedmundson.co.uk
Tue Feb 4 15:47:39 UTC 2014



> On Feb. 4, 2014, 3:42 p.m., Marco Martin wrote:
> > hm, no...
> > while the changes in this rr are fine, I would really really want the new repo with history preserved, at least the classes in src/plasma, with git filter-branch.
> > for examples and tests, history is less important.

It has history via git graft (tested here)


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115475/#review48931
-----------------------------------------------------------


On Feb. 4, 2014, 3:33 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115475/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2014, 3:33 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Splitted out KRunner so we can use it from any solution and eventually move out from it, if required.
> 
> It can be found now in kde:scratch/apol/krunner.
> 
> 
> Diffs
> -----
> 
>   src/plasma/includes/Plasma/RunnerScript f078d03 
>   src/plasma/pluginloader.cpp 4d8633c 
>   src/plasma/private/abstractrunner_p.h ada3222 
>   src/plasma/private/runnerjobs.cpp 880a3c5 
>   src/plasma/private/runnerjobs_p.h 43c6da2 
>   src/plasma/private/storage.cpp c9d7100 
>   src/plasma/querymatch.h 7fe66fb 
>   src/plasma/querymatch.cpp 8353e8f 
>   src/plasma/runnercontext.h 97d654a 
>   src/plasma/runnercontext.cpp 8b74614 
>   src/plasma/runnermanager.h 1963f66 
>   src/plasma/runnermanager.cpp 69f8ef4 
>   src/plasma/runnersyntax.h 63a2624 
>   src/plasma/runnersyntax.cpp 2984d7a 
>   src/plasma/scripting/runnerscript.h 1175d25 
>   src/plasma/scripting/runnerscript.cpp 366d3ef 
>   src/plasma/scripting/scriptengine.h 013e983 
>   src/plasma/scripting/scriptengine.cpp 2a0dfd9 
>   src/scriptengines/python/CMakeLists.txt 2bd980b 
>   src/plasma/includes/Plasma/RunnerContext 0c0d283 
>   src/plasma/includes/Plasma/RunnerManager 95e00ec 
>   src/declarativeimports/krunnermodel/qmldir 6e4fe5b 
>   src/declarativeimports/krunnermodel/runnermodelplugin.h 65d2faa 
>   src/declarativeimports/krunnermodel/runnermodelplugin.cpp 3b466bf 
>   src/plasma/CMakeLists.txt 064d3cc 
>   src/plasma/abstractrunner.h 219fa05 
>   src/plasma/abstractrunner.cpp c01ac18 
>   src/plasma/autotests/CMakeLists.txt 06c3d15 
>   src/plasma/autotests/runnercontexttest.h 1c6feb7 
>   src/plasma/autotests/runnercontexttest.cpp bb38d3e 
>   src/plasma/data/servicetypes/plasma-runner.desktop 08cd066 
>   src/plasma/includes/Plasma/AbstractRunner fbc77e8 
>   src/plasma/includes/Plasma/QueryMatch d6fc700 
>   examples/runner/homefilesrunner.cpp 39d0205 
>   examples/runner/plasma-runner-example-homefiles.desktop 296d1d0 
>   src/declarativeimports/CMakeLists.txt db88828 
>   src/declarativeimports/core/corebindingsplugin.cpp 1ce43d4 
>   src/declarativeimports/core/runnermodel.h bd21c21 
>   src/declarativeimports/core/runnermodel.cpp 170f511 
>   src/declarativeimports/core/tests/CMakeLists.txt b49f91d 
>   src/declarativeimports/core/tests/main.cpp 1feee19 
>   src/declarativeimports/krunnermodel/CMakeLists.txt f7405b6 
>   examples/runner/CMakeLists.txt b9c1511 
>   examples/runner/Messages.sh 4fb602e 
>   examples/runner/homefilesrunner.h c535380 
> 
> Diff: https://git.reviewboard.kde.org/r/115475/diff/
> 
> 
> Testing
> -------
> 
> Everything still builds.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140204/43963371/attachment-0001.html>


More information about the Plasma-devel mailing list