Review Request 115452: Use a single layout for panels
Marco Martin
notmart at gmail.com
Mon Feb 3 20:51:55 UTC 2014
> On Feb. 3, 2014, 8:31 p.m., Marco Martin wrote:
> > hmm, do minimum sizes and fillWidth/fillHeight keep working with it?
>
> David Edmundson wrote:
> It seems to. The task manager stretches to fit, and is the one that shrinks when I resize the panel.
> Internally the QtQuickLayouts Row object uses from QQuickGridLayoutBase which is a similar code path.
>
> It's not bug free, but I can't see any regressions from the current implementation.
Ok, so let's go for it.
a thing that would be nice to get in that import to be correct-correct is a LinearLayout class...
- Marco
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115452/#review48861
-----------------------------------------------------------
On Feb. 3, 2014, 8:10 p.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115452/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2014, 8:10 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: kde-workspace
>
>
> Description
> -------
>
> Use a single layout for panels
>
> Rather than having a row layout and a column layout have a grid layout
> limited to 1 row or 1 column.
>
> This saves any complex reparenting when switching views and seems to fix
> a bug with regards to keeping item ordering
>
>
> Diffs
> -----
>
> plasma/desktop/containments/panel/contents/ui/main.qml 15b1360
>
> Diff: https://git.reviewboard.kde.org/r/115452/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> David Edmundson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140203/ec050db5/attachment.html>
More information about the Plasma-devel
mailing list