Review Request 115448: Fix multiscreen popup positioning

[Martin Gräßlin]

> On Feb. 3, 2014, 6:07 p.m., Martin Gräßlin wrote:
> > src/declarativeimports/core/dialog.cpp, line 258
> > <https://git.reviewboard.kde.org/r/115448/diff/1/?file=241628#file241628line258>
> >
> >     why do you cast to int? That will break with https://git.reviewboard.kde.org/r/115442/
> 
> David Edmundson wrote:
>     well I didn't know about that review. It looks sensible.
>     
>     I need it ATM, as implicitly casting a long to an int will give a warning otherwise.

ah right, another reason why the change I put up today is needed (it was horrible to look through the code and see what kind of types were used for the same flags).


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115448/#review48842
-----------------------------------------------------------


On Feb. 3, 2014, 4:47 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115448/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2014, 4:47 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Fix multiscreen popup positioning
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/core/dialog.h fd6b0d0 
>   src/declarativeimports/core/dialog.cpp 8ce848f 
> 
> Diff: https://git.reviewboard.kde.org/r/115448/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140203/5b70ee44/attachment.html>