Review Request 115448: Fix multiscreen popup positioning

[Martin Klapetek]

> On Feb. 3, 2014, 5:40 p.m., Àlex Fiestas wrote:
> > src/declarativeimports/core/dialog.cpp, lines 299-301
> > <https://git.reviewboard.kde.org/r/115448/diff/1/?file=241628#file241628line299>
> >
> >     What does it represent then?

QWindow::screen() is always only the screen where the window gets first created (QPoint(0,0) iirc), Qt docs say that it will not change if you move it between virtual X11 screens, it will keep returning the same screen. Imho a Qt bug, but since it's explicitly mentioned in the docs, I guess it's intentional.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115448/#review48832
-----------------------------------------------------------


On Feb. 3, 2014, 4:47 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115448/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2014, 4:47 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Fix multiscreen popup positioning
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/core/dialog.h fd6b0d0 
>   src/declarativeimports/core/dialog.cpp 8ce848f 
> 
> Diff: https://git.reviewboard.kde.org/r/115448/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140203/ce208a55/attachment.html>