Review Request 115435: Add an option to uniform the style of time and data in digital clock applet

[Yichao Zhou]

> On Feb. 3, 2014, 9:34 a.m., Sebastian Kügler wrote:
> > Unfortunately, we have to discard this patch, as it adds a feature and kde-workspace has been in feature freeze for some time now.
> > 
> > The implementation in Plasma Next is an entirely different one, so this catch can't be carried there.

That's fine.  Hope that the clock in "Plasma Next" will have cleaner code and a nicer interface :)


- Yichao


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115435/#review48796
-----------------------------------------------------------


On Feb. 2, 2014, 12:31 p.m., Yichao Zhou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115435/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2014, 12:31 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> This patch adds an option to uniform the style (mainly font) of time and data in digital clock applet.
> 
> 
> Diffs
> -----
> 
>   plasma/generic/applets/digital-clock/clock.h f4822ec 
>   plasma/generic/applets/digital-clock/clock.cpp f26e328 
>   plasma/generic/applets/digital-clock/clockConfig.ui b58fb0b 
> 
> Diff: https://git.reviewboard.kde.org/r/115435/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Yichao Zhou
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140203/d1d3d9ec/attachment.html>