Review Request 115431: Fix the numbers cut off problem in digital clock applet

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115431/#review48794
-----------------------------------------------------------


This seems pretty clever. Thanks.
A few comments below.


plasma/generic/applets/digital-clock/clock.cpp
<https://git.reviewboard.kde.org/r/115431/#comment34452>

    Either
    
    int smallestReadableFont().pointSize();
    
    OR
    
    qreal smallestReadableFont().pointSizeF();
    
    
    Right now you're creating a float which is always going to be an integer, which is pointless.



plasma/generic/applets/digital-clock/clock.cpp
<https://git.reviewboard.kde.org/r/115431/#comment34449>

    myText is an unhelpful variable name.
    Can we think of something better? Maybe "maximumWidthTetx" or something?



plasma/generic/applets/digital-clock/clock.cpp
<https://git.reviewboard.kde.org/r/115431/#comment34450>

    Why this change?


- David Edmundson


On Feb. 2, 2014, 12:31 p.m., Yichao Zhou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115431/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2014, 12:31 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 228902
>     http://bugs.kde.org/show_bug.cgi?id=228902
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> For bug, see
> https://bugs.launchpad.net/ubuntu/+source/kde-workspace/+bug/1052059 and
> https://bugs.kde.org/show_bug.cgi?id=228902
> 
> The problem is that in original code, it always uses 23:59 to calculate the width of the text.  However, in some font, AM is wider than PM, and 0 is wider than 2 and 5.  That causes some fonts been cropped.
> 
> 
> Diffs
> -----
> 
>   plasma/generic/applets/digital-clock/clock.cpp f26e328 
> 
> Diff: https://git.reviewboard.kde.org/r/115431/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Yichao Zhou
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140203/1a2d5057/attachment.html>