Review Request 115431: Fix the numbers cut off problem in digital clock

Yichao Zhou broken.zhou at
Sun Feb 2 12:27:05 UTC 2014

This is an automatically generated e-mail. To reply, visit:

(Updated Feb. 2, 2014, 12:27 p.m.)

Review request for Plasma.


Remove the "code cleanup".  These codes are necessary.  (OK KDE's clock is the most ugly code I have ever seen.)

Bugs: 228902

Repository: kde-workspace


For bug, see and

The problem is that in original code, it always uses 23:59 to calculate the width of the text.  However, in some font, AM is wider than PM, and 0 is wider than 2 and 5.  That causes some fonts been cropped.

Also I do a code cleanup:  I delete m_isDefaultFont and expandFontToMax, which I think it is not longer useful.  We do not need to distinguish whether we are using the default font or not.

Diffs (updated)

  plasma/generic/applets/digital-clock/clock.cpp f26e328 




Yichao Zhou

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the Plasma-devel mailing list