Review Request 115431: Fix the numbers cut off problem in digital clock

Yichao Zhou broken.zhou at
Sun Feb 2 08:17:41 UTC 2014

This is an automatically generated e-mail. To reply, visit:

Review request for Plasma.

Bugs: 228902

Repository: kde-workspace


For bug, see and

The problem is that in original code, it always uses 23:59 to calculate the width of the text.  However, in some font, AM is wider than PM, and 0 is wider than 2 and 5.  That cause some fonts been cropped.

Also I do a code cleanup:  I delete m_isDefaultFont and expandFontToMax, which I think it is not longer useful.  I do not need to distinguish whether we are using the default font.


  plasma/generic/applets/digital-clock/clock.h f4822ec 
  plasma/generic/applets/digital-clock/clock.cpp f26e328 




Yichao Zhou

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the Plasma-devel mailing list