Review Request 114260: Port mouse dataengine

Andrea Scarpino scarpino at kde.org
Sat Feb 1 09:00:19 UTC 2014



> On Dec. 8, 2013, 1:08 p.m., Bhushan Shah wrote:
> > plasma/generic/dataengines/mouse/mouseengine.cpp, line 34
> > <https://git.reviewboard.kde.org/r/114260/diff/2/?file=222312#file222312line34>
> >
> >     You should call init() here. Have a look at http://community.kde.org/Plasma/PortingTolibplasma2#DataEngine for changes in API.
> 
> Alex Merry wrote:
>     Any update on this?

Oh, I totally forgot about this.
I can't fix it ATM, but I'll.


- Andrea


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114260/#review45349
-----------------------------------------------------------


On Dec. 3, 2013, 10:51 a.m., Andrea Scarpino wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114260/
> -----------------------------------------------------------
> 
> (Updated Dec. 3, 2013, 10:51 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> = subject.
> 
> I commented the lines about scheduleSourcesUpdated(). What to do with them?
> 
> 
> Diffs
> -----
> 
>   plasma/generic/dataengines/CMakeLists.txt 3e94325 
>   plasma/generic/dataengines/mouse/CMakeLists.txt 29cab87 
>   plasma/generic/dataengines/mouse/cursornotificationhandler.h 3b571f8 
>   plasma/generic/dataengines/mouse/cursornotificationhandler.cpp 3cb9add 
>   plasma/generic/dataengines/mouse/mouseengine.h d55565d 
>   plasma/generic/dataengines/mouse/mouseengine.cpp 19a7fb7 
> 
> Diff: https://git.reviewboard.kde.org/r/114260/diff/
> 
> 
> Testing
> -------
> 
> Builds
> 
> 
> Thanks,
> 
> Andrea Scarpino
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140201/4181e4e3/attachment.html>


More information about the Plasma-devel mailing list