Review Request 121763: Fix build on FreeBSD
David Edmundson
david at davidedmundson.co.uk
Wed Dec 31 10:47:30 UTC 2014
> On Dec. 30, 2014, 6:50 p.m., Raphael Kubo da Costa wrote:
> > Looks fine to me, not sure if someone else needs to approve.
>not sure if someone else needs to approve.
You know your stuff, if you're happy with a patch and it's obviously not going to be controversial feel free to click "ship it!".
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121763/#review72791
-----------------------------------------------------------
On Dec. 30, 2014, 6:48 p.m., Alex Richardson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121763/
> -----------------------------------------------------------
>
> (Updated Dec. 30, 2014, 6:48 p.m.)
>
>
> Review request for Plasma and Raphael Kubo da Costa.
>
>
> Repository: kinfocenter
>
>
> Description
> -------
>
> We can't call the KCM devinfo there since we need to link against -ldevinfo
> and CMake would try to link to the KCM instead of the library in that case.
>
>
> Diffs
> -----
>
> Modules/devinfo/CMakeLists.txt 2395ce3dc83080e959cbfa9f97724218cdff6bd9
> Modules/devinfo/devinfo.desktop 1bc98a06b9a567ee45c51c7f25ee5ad6b43750d7
> Modules/info/CMakeLists.txt 7b0e0affd13d6b556749f4a350012f27fb43ae0b
> Modules/pci/CMakeLists.txt 5b2b30a0c3791a8add00a380e61469a96cd66ae1
>
> Diff: https://git.reviewboard.kde.org/r/121763/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Richardson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141231/31f65b44/attachment-0001.html>
More information about the Plasma-devel
mailing list