Review Request 121771: Notify panels when dashboard is shown
David Edmundson
david at davidedmundson.co.uk
Wed Dec 31 10:33:42 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121771/#review72823
-----------------------------------------------------------
IMHO, it's a bit too applicaiton specific.
Given kwin does most the dashboard work, and it knows what a panel is it could do the fading.
- David Edmundson
On Dec. 31, 2014, 10:01 a.m., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121771/
> -----------------------------------------------------------
>
> (Updated Dec. 31, 2014, 10:01 a.m.)
>
>
> Review request for Plasma.
>
>
> Bugs: 342123
> https://bugs.kde.org/show_bug.cgi?id=342123
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> This exposes a panel.dashboardShown property similar to the desktop view which allows the panels to react on it being shown.
> It leaves the actual reaction (hide, dim, whatever) to the desktoppackage since a diferent formfactor might want to handle this differently.
>
>
> Diffs
> -----
>
> shell/panelview.h d1ef282
> shell/panelview.cpp b7f043d
> shell/shellcorona.cpp c26efe5
>
> Diff: https://git.reviewboard.kde.org/r/121771/diff/
>
>
> Testing
> -------
>
> Panel can now react on it.
>
>
> Thanks,
>
> Kai Uwe Broulik
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141231/363038f6/attachment.html>
More information about the Plasma-devel
mailing list