Review Request 121581: Plotter in kdeclarative

Marco Martin notmart at gmail.com
Mon Dec 29 12:17:07 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121581/
-----------------------------------------------------------

(Updated Dec. 29, 2014, 12:17 p.m.)


Review request for KDE Frameworks and Plasma.


Repository: kdeclarative


Description
-------

This is an alternative, mutually exclusive to
https://gerrit.vesnicky.cesnet.cz/r/#/c/244
and dependent from
https://git.reviewboard.kde.org/r/121575/

since the plotter component doesn't depend from libplasma, it may be useful to have it outside of libplasma, so any applciation that wants it may use it.
Any opinion whether this should go here or in libplasma is welcome.


Diffs (updated)
-----

  src/qmlcontrols/kquickcontrolsaddons/kquickcontrolsaddonsplugin.cpp 0e2eb2f 
  src/qmlcontrols/kquickcontrolsaddons/plotter.h PRE-CREATION 
  src/qmlcontrols/kquickcontrolsaddons/plotter.cpp PRE-CREATION 
  CMakeLists.txt 233ccce 
  cmake/Findepoxy.cmake PRE-CREATION 
  src/qmlcontrols/kquickcontrolsaddons/CMakeLists.txt 786aaa5 

Diff: https://git.reviewboard.kde.org/r/121581/diff/


Testing
-------


Thanks,

Marco Martin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141229/277ea407/attachment.html>


More information about the Plasma-devel mailing list