Review Request 121720: Load wallpaper immediately on startup

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121720/#review72690
-----------------------------------------------------------

Ship it!


Ship It!

- Marco Martin


On Dec. 28, 2014, 7:49 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121720/
> -----------------------------------------------------------
> 
> (Updated Dec. 28, 2014, 7:49 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> When the shell starts we want the wallpaper to show up immediately to get a seamless transition from ksplash.
> This patch also hides the background color rectangle while the image is not ready yet to prevent it appearing for a split second.
> The add wallpaper stuff in Component.onCompleted has been removed since the function got fired twice due to the onModelImageChanged which seems to be executed anyway.
> 
> 
> Diffs
> -----
> 
>   wallpapers/image/imagepackage/contents/ui/main.qml 0cb4812 
> 
> Diff: https://git.reviewboard.kde.org/r/121720/diff/
> 
> 
> Testing
> -------
> 
> Logged in, splash screen disappears and the wallpaper is already there. The image seems to be loading fine too.
> 
> The slideshow also no longer initially loads the default wallpaper but just black and then fade to the slideshow (but this is a bug in the image.cpp where it falls back to the default wallpaper even initially when it's still crawling for images (depending on the number of files it has to scan the default wallpaper can stay there for a second or two))
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141229/476dc5c3/attachment-0001.html>