Review Request 121728: Fix Label not picking up font changes at runtime
David Edmundson
david at davidedmundson.co.uk
Sun Dec 28 22:34:08 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121728/#review72636
-----------------------------------------------------------
Ship it!
src/plasma/private/theme_p.cpp
<https://git.reviewboard.kde.org/r/121728/#comment50613>
so to confirm, it's redundant because we also have this line.
- David Edmundson
On Dec. 28, 2014, 10:22 p.m., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121728/
> -----------------------------------------------------------
>
> (Updated Dec. 28, 2014, 10:22 p.m.)
>
>
> Review request for Plasma.
>
>
> Bugs: 334818
> http://bugs.kde.org/show_bug.cgi?id=334818
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> The event filter was installed but then removed when the color file path was not empty (read: always). Keeping the event filter around ensures font changes are picked up at runtime.
>
>
> Diffs
> -----
>
> src/plasma/private/theme_p.cpp 1963f74
>
> Diff: https://git.reviewboard.kde.org/r/121728/diff/
>
>
> Testing
> -------
>
> Changed my fonts to bold or changed the size, everything updated like magic after hitting the Apply button.
>
>
> Thanks,
>
> Kai Uwe Broulik
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141228/6f3fe981/attachment.html>
More information about the Plasma-devel
mailing list