Review Request 121701: Introduce KQuickControls TextField with context menu

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121701/#review72575
-----------------------------------------------------------


+1 from me.
(with typo fixed)

As it's new API I don't want to +2 it immediately


src/qmlcontrols/kquickcontrols/qmldir
<https://git.reviewboard.kde.org/r/121701/#comment50593>

    *cough*


- David Edmundson


On Dec. 27, 2014, 7:17 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121701/
> -----------------------------------------------------------
> 
> (Updated Dec. 27, 2014, 7:17 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> -------
> 
> This adds a KQuickControls TextField and TextArea with a context menu similar to what the widgets provide, based on Review 121698.
> 
> It uses the new "menu" property and thus requires QtQuick.Controls 1.3, ie. Qt 5.4 and should eventually be used as base for its PlasmaComponents counterparts. A user of this Item could manupulate menu to remove or add additional items.
> 
> 
> Diffs
> -----
> 
>   src/qmlcontrols/kquickcontrols/CMakeLists.txt eef0420 
>   src/qmlcontrols/kquickcontrols/TextArea.qml PRE-CREATION 
>   src/qmlcontrols/kquickcontrols/TextField.qml PRE-CREATION 
>   src/qmlcontrols/kquickcontrols/private/CMakeLists.txt c024800 
>   src/qmlcontrols/kquickcontrols/private/TextMenu.qml PRE-CREATION 
>   src/qmlcontrols/kquickcontrols/private/qmldir 8770bce 
>   src/qmlcontrols/kquickcontrols/qmldir 31d8b14 
> 
> Diff: https://git.reviewboard.kde.org/r/121701/diff/
> 
> 
> Testing
> -------
> 
> Works in qmlscene, was too lazy recompiling the frameworksintegration for Qt 5.4
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141227/65660340/attachment.html>