Review Request 121697: Add MenuItem enabled property
David Edmundson
david at davidedmundson.co.uk
Sat Dec 27 17:33:21 UTC 2014
> On Dec. 27, 2014, 5:24 p.m., David Edmundson wrote:
> > src/declarativeimports/plasmacomponents/qmenuitem.h, line 45
> > <https://git.reviewboard.kde.org/r/121697/diff/1/?file=336010#file336010line45>
> >
> > this is missing a connect
> >
> > m_action, enabledChanged, this, enabledChanged
>
> Kai Uwe Broulik wrote:
> There's already one:
>
> connect(this, &QQuickItem::enabledChanged, this, &QMenuItem::updateAction);
>
> Kai Uwe Broulik wrote:
> Ohhh, shit, so does it mean that it uses QQuickItem's enabled property and mine isn't needed in the first place? \o/
that's not quite everything;
Given QActions are modifiable from C++ for external reasons, we need to connect the QAction object changing and update the C++ wrapper.
also as you just pointed out; redeclaring the enabled property probably isn't a good idea :)
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121697/#review72558
-----------------------------------------------------------
On Dec. 27, 2014, 4:02 p.m., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121697/
> -----------------------------------------------------------
>
> (Updated Dec. 27, 2014, 4:02 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> This forwards the internal QAction's enabled property.
>
> It's a bit unfornuate that you cannot use QQuickAction (aka QtControls.Action {}) for "action", only C++ QAction works.
>
>
> Diffs
> -----
>
> src/declarativeimports/plasmacomponents/qmenuitem.h f8629f0
> src/declarativeimports/plasmacomponents/qmenuitem.cpp 1d9076f
>
> Diff: https://git.reviewboard.kde.org/r/121697/diff/
>
>
> Testing
> -------
>
> MenuItem with "enabled" bound to things properly activates and deactivates the entry.
>
>
> Thanks,
>
> Kai Uwe Broulik
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141227/959b4154/attachment.html>
More information about the Plasma-devel
mailing list