Review Request 121697: Add MenuItem enabled property

[Kai Uwe Broulik]

> On Dez. 27, 2014, 5:24 nachm., David Edmundson wrote:
> > src/declarativeimports/plasmacomponents/qmenuitem.h, line 45
> > <https://git.reviewboard.kde.org/r/121697/diff/1/?file=336010#file336010line45>
> >
> >     this is missing a connect
> >     
> >     m_action, enabledChanged, this, enabledChanged

There's already one:

connect(this, &QQuickItem::enabledChanged, this, &QMenuItem::updateAction);


- Kai Uwe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121697/#review72558
-----------------------------------------------------------


On Dez. 27, 2014, 4:02 nachm., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121697/
> -----------------------------------------------------------
> 
> (Updated Dez. 27, 2014, 4:02 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> This forwards the internal QAction's enabled property.
> 
> It's a bit unfornuate that you cannot use QQuickAction (aka QtControls.Action {}) for "action", only C++ QAction works.
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/plasmacomponents/qmenuitem.h f8629f0 
>   src/declarativeimports/plasmacomponents/qmenuitem.cpp 1d9076f 
> 
> Diff: https://git.reviewboard.kde.org/r/121697/diff/
> 
> 
> Testing
> -------
> 
> MenuItem with "enabled" bound to things properly activates and deactivates the entry.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141227/7f4a8b7c/attachment.html>