Review Request 121695: Use ColorDialog for color selection in wallpapers

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121695/
-----------------------------------------------------------

(Updated Dec. 27, 2014, 2:32 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Repository: plasma-workspace


Description
-------

Use QtQuick.Dialogs.ColorDialog for selecting the wallpaper background color rather than that DIY Canvas thing.

Since we neither have the ability to replace the QQC Button's text item (while still using the native background) nor the ability to query for its margins the Button has a Rectangle superimposed ontop of it using the font height and magic number margins David strongly advised against :)


Diffs
-----

  wallpapers/color/contents/ui/config.qml 4776aaf 
  wallpapers/image/imagepackage/contents/ui/ColorPicker.qml 017029b 
  wallpapers/image/imagepackage/contents/ui/config.qml 7e12e7b 

Diff: https://git.reviewboard.kde.org/r/121695/diff/


Testing
-------

The color picker no longer looks out of place and I adjusted the layout of the color wallpaper a bit to match the rest.


File Attachments
----------------

Image package
  https://git.reviewboard.kde.org/media/uploaded/files/2014/12/27/87c0d997-1003-4368-823c-efcd0f3675c8__colorpickerwallpaper.png
Color package
  https://git.reviewboard.kde.org/media/uploaded/files/2014/12/27/219f85f9-dd21-446a-9529-50e9876a0c55__colorpickerwallpaper1.png


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141227/2fcdfefe/attachment.html>