Review Request 121554: Simple network systemmonitor plasmoid rewrite

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121554/#review72446
-----------------------------------------------------------



applets/systemmonitor/contents/ui/configGeneral.qml
<https://git.reviewboard.kde.org/r/121554/#comment50490>

    no it isn't?



applets/systemmonitor/contents/ui/configGeneral.qml
<https://git.reviewboard.kde.org/r/121554/#comment50491>

    as arrays don't signal the apply button surely isn't going to work?


If this is the only thing that is going to be using the plotter, I really don't think it's worth rushing it if it isn't ready by 5.6

- David Edmundson


On Dec. 16, 2014, 1:39 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121554/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2014, 1:39 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> a simple rewrite of the "network" systemmonitor plasmoid, using the new "plotter" component from extracomponents
> 
> 
> Diffs
> -----
> 
>   applets/systemmonitor/metadata.desktop PRE-CREATION 
>   applets/systemmonitor/contents/config/main.xml PRE-CREATION 
>   applets/systemmonitor/contents/ui/configGeneral.qml PRE-CREATION 
>   applets/systemmonitor/contents/ui/net.qml PRE-CREATION 
>   applets/systemmonitor/contents/config/config.qml PRE-CREATION 
>   applets/CMakeLists.txt c4d40ac 
>   applets/systemmonitor/Messages.sh PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/121554/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> sysmon.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/12/16/4b5ba6d2-bc5e-4369-9f1e-ce80d510c894__sysmon.png
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141223/986f49be/attachment-0001.html>