Review Request 121563: Fix build with Qt 5.5/dev branch in release mode

Martin Gräßlin mgraesslin at kde.org
Wed Dec 17 06:57:57 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121563/#review72162
-----------------------------------------------------------


but that will now create a unused variable warning in release mode...

- Martin Gräßlin


On Dec. 16, 2014, 7:19 p.m., Hrvoje Senjan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121563/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2014, 7:19 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: libksysguard
> 
> 
> Description
> -------
> 
> same as review 121562:
> "since qtbase commit ebef2ad1360c80ad62de5f4a1c4e7e4051725c1c "Make the empty Q_ASSERT still check its argument for validity" the build shall fail.
> alternative is to guard the Q_ASSERT with QT_NO_DEBUG"
> 
> 
> Diffs
> -----
> 
>   processcore/processes.cpp 6c0effc 
> 
> Diff: https://git.reviewboard.kde.org/r/121563/diff/
> 
> 
> Testing
> -------
> 
> builds with both 5.4 & dev branch
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141217/71acd051/attachment.html>


More information about the Plasma-devel mailing list