Review Request 121554: Simple network systemmonitor plasmoid rewrite

Lukáš Tinkl lukas at kde.org
Tue Dec 16 13:32:49 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121554/#review72120
-----------------------------------------------------------


The usual nitpick, I'm missing Messages.sh and the catalog loading :)

- Lukáš Tinkl


On Pro. 16, 2014, 2:25 odp., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121554/
> -----------------------------------------------------------
> 
> (Updated Pro. 16, 2014, 2:25 odp.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> a simple rewrite of the "network" systemmonitor plasmoid, using the new "plotter" component from extracomponents
> 
> 
> Diffs
> -----
> 
>   applets/CMakeLists.txt c4d40ac 
>   applets/systemmonitor/contents/config/config.qml PRE-CREATION 
>   applets/systemmonitor/contents/config/main.xml PRE-CREATION 
>   applets/systemmonitor/contents/ui/configGeneral.qml PRE-CREATION 
>   applets/systemmonitor/contents/ui/net.qml PRE-CREATION 
>   applets/systemmonitor/metadata.desktop PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/121554/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> sysmon.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/12/16/4b5ba6d2-bc5e-4369-9f1e-ce80d510c894__sysmon.png
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141216/df026568/attachment.html>


More information about the Plasma-devel mailing list