Review Request 121533: Register actions for activities management

[Bhushan Shah]

> On Dec. 15, 2014, 8:57 p.m., Lukáš Tinkl wrote:
> > shell/shellcorona.cpp, line 1491
> > <https://git.reviewboard.kde.org/r/121533/diff/1/?file=333370#file333370line1491>
> >
> >     Ha? :)

nah


> On Dec. 15, 2014, 8:57 p.m., Lukáš Tinkl wrote:
> > shell/shellcorona.cpp, line 170
> > <https://git.reviewboard.kde.org/r/121533/diff/1/?file=333370#file333370line170>
> >
> >     You can use KGlobalAccel::setGlobalShortcut() which sets both the default and active shortcuts, instead of those 2 lines

mgraesslin had better solution


- Bhushan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121533/#review72063
-----------------------------------------------------------


On Dec. 15, 2014, 9:11 p.m., Bhushan Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121533/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2014, 9:11 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 341856
>     https://bugs.kde.org/show_bug.cgi?id=341856
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> In Plasma 4 plasma-desktop registered global shortcuts for activities management
> 
> Add those actions back
> 
> 
> Diffs
> -----
> 
>   shell/shellcorona.h 7c25cd4 
>   shell/shellcorona.cpp c416217 
> 
> Diff: https://git.reviewboard.kde.org/r/121533/diff/
> 
> 
> Testing
> -------
> 
> all shortcuts, Meta + Q, Meta + Tab and Meta + Shift + Tab works fine
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141215/ee9f47a8/attachment.html>