Review Request 119814: [ksld] ScreenLocker inhibits sleep on logind

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119814/
-----------------------------------------------------------

(Updated Dec. 15, 2014, 11:18 a.m.)


Review request for Plasma and Àlex Fiestas.


Changes
-------

* rebased on current master
* added config option for "lock screen on resume"


Repository: plasma-workspace


Description
-------

[ksld] ScreenLocker inhibits sleep on logind

When the system is going to sleep we want to ensure that the screen gets
locked before the system goes to sleep. Logind provides the inhibitor
locks which can be used for this.

If logind is available ksld gains an inhibitor lock for sleep when the
screen is unlocked. As soon as the screen gets locked the inhibitor lock
is released. In addition it connects to the prepareForSleep signal by
logind and locks the screen.

The solution needs to be extended to have a config option whether the
screen should be locked on sleep. Currently this is provided by
powerdevil. Also the solution can only work properly if power devil uses
logind's sleep dbus interface.

[ksld] Don't block till the greeter is started

We only want to ensure that the greeter gets started. There is no
need to block for that. Instead we can connect to the error signal
and unlock in case the greeter failed to start.


-----
@Alex: what do you think is the best solution for handling the "lock screen on resume" config option? My idea would be to move it to screen locker and expose the value through DBus, so that powerdevil can still read it.


Diffs (updated)
-----

  ksmserver/screenlocker/CMakeLists.txt 5378a10df2be70cee95b5612c23046eae639f610 
  ksmserver/screenlocker/autotests/CMakeLists.txt 4bff1c6b1d8fc360197c422f8d036dff3eae5efe 
  ksmserver/screenlocker/kcfg/kscreenlockersettings.kcfg a0253d687150702aa4c22200d9f6a577d0cab6be 
  ksmserver/screenlocker/kcm/kcm.ui 8f8654b5fe34b8e4bfd95f652659a59c6c664a55 
  ksmserver/screenlocker/ksldapp.h 095424c9845c134aa156917aeb6c8ddf31e8d25a 
  ksmserver/screenlocker/ksldapp.cpp 22698ce37e9d4be17126111b3ded8133f7c3baa6 
  ksmserver/screenlocker/logind.h a335ddc2f6f55b071f824f9da94652a4dd70c483 
  ksmserver/screenlocker/logind.cpp dcfc7f321b3cf29ef68aac8006aa37f5e4e00956 

Diff: https://git.reviewboard.kde.org/r/119814/diff/


Testing
-------


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141215/cffd0271/attachment.html>