Review Request 121473: Port mouse dataengine

[Fredrik Höglund]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121473/#review71925
-----------------------------------------------------------



dataengines/mouse/cursornotificationhandler.cpp
<https://git.reviewboard.kde.org/r/121473/#comment50146>

    QWidget is not an X window in Qt 5.



dataengines/mouse/cursornotificationhandler.cpp
<https://git.reviewboard.kde.org/r/121473/#comment50145>

    The virtual function reimplemented here doesn't even exist in Qt 5.
    Qt 5 does not use XEvents.


I know this has already been submitted thanks to Bhushan, but I really have to add a -2 here.

This code has clearly not been ported at all!

Did you even test this before you pushed it, or is this a case of "It builds, ship it"?
The fact that others had to tell you that it doesn't build suggests that you didn't even try building it.

- Fredrik Höglund


On Dec. 13, 2014, 12:50 p.m., Andrea Scarpino wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121473/
> -----------------------------------------------------------
> 
> (Updated Dec. 13, 2014, 12:50 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Rebased https://git.reviewboard.kde.org/r/114260/
> 
> 
> Diffs
> -----
> 
>   dataengines/mouse/mouseengine.h d55565dc3875b794dce14054d9a8b77cef9b2347 
>   dataengines/mouse/mouseengine.cpp f1c898150e04b44dad1c8a0fc757c1ffdf94941b 
>   dataengines/CMakeLists.txt cae926b550cdd69aa0194e19bc4818c597e174c0 
>   dataengines/mouse/CMakeLists.txt 29cab878bd1fb514d7ac025134fbfb58a5a1376e 
>   dataengines/mouse/cursornotificationhandler.h 3b571f8f5ffe6db4efeef7827acf003911bcd5dc 
>   dataengines/mouse/cursornotificationhandler.cpp cf1c3fbe91a9afee5090d167dd6cd51637df04d4 
> 
> Diff: https://git.reviewboard.kde.org/r/121473/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrea Scarpino
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141213/6e78cea1/attachment.html>