Review Request 121476: Port showdesktop applet to Plasma Next
Ashish Madeti
ashishmadeti at gmail.com
Sat Dec 13 15:55:14 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121476/
-----------------------------------------------------------
(Updated Dec. 13, 2014, 9:25 p.m.)
Review request for Plasma and Bhushan Shah.
Changes
-------
Fixed the issues pointed by Vishesh and IMHO delay(), reset() slots are not needed anymore.
Repository: kdeplasma-addons
Description
-------
Ported the "Show Desktop" applet to Plasma Next.
Most of the code is derived from the old showdesktop applet.
Diffs (updated)
-----
CMakeLists.txt db03015
applets/CMakeLists.txt ccd1bf7
applets/showdesktop/CMakeLists.txt eb53207
applets/showdesktop/package/contents/config/main.xml PRE-CREATION
applets/showdesktop/package/contents/ui/main.qml PRE-CREATION
applets/showdesktop/package/metadata.desktop PRE-CREATION
applets/showdesktop/plasma-applet-showdesktop.desktop f36a1da
applets/showdesktop/plugin/qmldir PRE-CREATION
applets/showdesktop/plugin/showdesktop.h PRE-CREATION
applets/showdesktop/plugin/showdesktop.cpp PRE-CREATION
applets/showdesktop/plugin/showdesktopplugin.h PRE-CREATION
applets/showdesktop/plugin/showdesktopplugin.cpp PRE-CREATION
applets/showdesktop/showdesktop.h 5aeb848
applets/showdesktop/showdesktop.cpp d712519
Diff: https://git.reviewboard.kde.org/r/121476/diff/
Testing
-------
Tested the applet locally, working fine.
Thanks,
Ashish Madeti
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141213/6ad93b1c/attachment.html>
More information about the Plasma-devel
mailing list