Review Request 114260: Port mouse dataengine

[Bhushan Shah]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114260/#review71914
-----------------------------------------------------------



plasma/generic/dataengines/mouse/CMakeLists.txt
<https://git.reviewboard.kde.org/r/114260/#comment50136>

    use kcoreaddons_desktop_to_json, kservice_desktop_to_json will yeild warning at runtime and cmake time.



plasma/generic/dataengines/mouse/CMakeLists.txt
<https://git.reviewboard.kde.org/r/114260/#comment50135>

    Use KF5::KDELibs4Support, KF5::KDE4Support target is deprecated and only provided for comptaibility now, alternatively port away from KDELibs4Support.. :p


- Bhushan Shah


On Dec. 13, 2014, 3 p.m., Andrea Scarpino wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114260/
> -----------------------------------------------------------
> 
> (Updated Dec. 13, 2014, 3 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> = subject.
> 
> I commented the lines about scheduleSourcesUpdated(). What to do with them?
> 
> 
> Diffs
> -----
> 
>   plasma/generic/dataengines/mouse/mouseengine.cpp 19a7fb7405647963ebadb4f71104e8164b729df7 
>   plasma/generic/dataengines/mouse/mouseengine.h d55565dc3875b794dce14054d9a8b77cef9b2347 
>   plasma/generic/dataengines/mouse/cursornotificationhandler.cpp 3cb9add2ec1d4cb4d5904a381b8ba8f29279e05b 
>   plasma/generic/dataengines/CMakeLists.txt 5e9f11bcef806576946257bdeaa40efb445b7daf 
>   plasma/generic/dataengines/mouse/CMakeLists.txt 29cab878bd1fb514d7ac025134fbfb58a5a1376e 
>   plasma/generic/dataengines/mouse/cursornotificationhandler.h 3b571f8f5ffe6db4efeef7827acf003911bcd5dc 
> 
> Diff: https://git.reviewboard.kde.org/r/114260/diff/
> 
> 
> Testing
> -------
> 
> Builds
> 
> 
> Thanks,
> 
> Andrea Scarpino
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141213/82e47745/attachment.html>