Review Request 121219: Load IconItem immediately upon componentComplete()

[David Edmundson]

> On Dec. 10, 2014, 6:12 p.m., David Edmundson wrote:
> > src/declarativeimports/core/iconitem.cpp, line 307
> > <https://git.reviewboard.kde.org/r/121219/diff/3/?file=332007#file332007line307>
> >
> >     Found one of the reasons for the blurring.
> >     
> >     To some extent, your first patch was right before I told you to change it (sorry!)
> >     
> >     when the input size is 0,0
> >     
> >     Units::roundToIconSize(0,0) returns 8.
> >     size is now not <= 0 so we load something.
> >     
> >     This means we'll animate when it gets a valid size.
> >     
> >     IMHO roundToIconSize should return 0 in this special case, as right now we have an entire code path that will never be used. 
> >     
> >     I don't know if that will cause other problems.
> >     
> >     
> >     We never hit this before, because setSource() has a size check, but we now call loadPixmap directly in componentComplete()
> 
> David Edmundson wrote:
>     opened here. https://gerrit.vesnicky.cesnet.cz/r/#/c/213/
>     
>     Kai, can you see if it fixes anything/everything?
> 
> Kai Uwe Broulik wrote:
>     Thanks!
>     
>     With this patch I no longer see initially massively pixelated icons in the lock screen. The issue persists for systemtray but I guess the issue lies in there then.

Xuetian did some investigation into the system tray; it resizes all plasmoids to 1x1, which my patch still counts as a valid size. Worst case, I ammend my patch, but I'd like to try and fix the systray to do something less odd.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121219/#review71735
-----------------------------------------------------------


On Dec. 5, 2014, 9:20 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121219/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2014, 9:20 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> This makes the IconItem load the icon immediately after component creation and not wait 150ms there for no reason which prevents eg. flickering in the OSD when it shows up.
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/core/iconitem.h 8aecd17 
>   src/declarativeimports/core/iconitem.cpp ed3bb97 
> 
> Diff: https://git.reviewboard.kde.org/r/121219/diff/
> 
> 
> Testing
> -------
> 
> Totally forgot about that, just took it for granted that the OSD wouldn't flicker anymore.
> Resizing applets still has it scale the texture before re-rendering it.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141213/c11a5455/attachment.html>