Re: Review Request 121439: systemtrayicon: pass icon’s name(), not themeName() to showMessage

[Dmitry Shachnev]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121439/
-----------------------------------------------------------

(Updated Dec. 11, 2014, 9:26 a.m.)


Review request for Plasma and Martin Gräßlin.


Changes
-------

Added plasma review group


Repository: frameworkintegration


Description
-------

Documentation of KStatusNotifierItem::showMessage() says:

const QString &icon | icon to be shown to the user

So we need name of the icon here, not name of the theme.


Diffs
-----

  src/platformtheme/kdeplatformsystemtrayicon.cpp 51f31ad 

Diff: https://git.reviewboard.kde.org/r/121439/diff/


Testing
-------


Thanks,

Dmitry Shachnev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141211/ef7689a9/attachment.html>