Review Request 120970: Remove combo "Graphical Effects"
Lukáš Tinkl
lukas at kde.org
Wed Dec 10 15:19:07 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120970/#review71713
-----------------------------------------------------------
I think this change has to be reverted, the setting in question is being used in frameworkintegration to set the level of graphical details to Qt, thru the QPA plugin:
m_hints[QPlatformTheme::UiEffects] = cg.readEntry("GraphicEffectsLevel", 0) != 0 ? QPlatformTheme::GeneralUiEffect : 0;
- Lukáš Tinkl
On Pro. 10, 2014, 3:49 odp., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120970/
> -----------------------------------------------------------
>
> (Updated Pro. 10, 2014, 3:49 odp.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-desktop
>
>
> Description
> -------
>
> Remove combo "Graphical Effects"
>
> It set a config value which was exposed in
> KGlobalSettings::graphicEffectsLevel that is now deprecated.
>
>
> Diffs
> -----
>
> kcms/style/finetuning.ui 3abb692
> kcms/style/kcmstyle.cpp 6585ee6
>
> Diff: https://git.reviewboard.kde.org/r/120970/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> David Edmundson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141210/6ca11211/attachment.html>
More information about the Plasma-devel
mailing list