Review Request 121219: Load IconItem immediately upon componentComplete()
David Edmundson
david at davidedmundson.co.uk
Wed Dec 10 14:35:14 UTC 2014
> On Dec. 8, 2014, 11:20 p.m., Aleix Pol Gonzalez wrote:
> > +1
> >
> > Looks good to me
>
> Kai Uwe Broulik wrote:
> I now experience a lot of situtations where icons start blurry and fade to their full size again, like when opening systray for the first time or locking the session where it's quite severe. :/
>
> Xuetian Weng wrote:
> The blurry transition is there before this change. I tried to create a patch for fixing this (depends on your change): https://git.reviewboard.kde.org/r/121411/
Can you give a reproducible case of this blurry -> full.
Then we can fill this with qDebugs.
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121219/#review71601
-----------------------------------------------------------
On Dec. 5, 2014, 9:20 p.m., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121219/
> -----------------------------------------------------------
>
> (Updated Dec. 5, 2014, 9:20 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> This makes the IconItem load the icon immediately after component creation and not wait 150ms there for no reason which prevents eg. flickering in the OSD when it shows up.
>
>
> Diffs
> -----
>
> src/declarativeimports/core/iconitem.h 8aecd17
> src/declarativeimports/core/iconitem.cpp ed3bb97
>
> Diff: https://git.reviewboard.kde.org/r/121219/diff/
>
>
> Testing
> -------
>
> Totally forgot about that, just took it for granted that the OSD wouldn't flicker anymore.
> Resizing applets still has it scale the texture before re-rendering it.
>
>
> Thanks,
>
> Kai Uwe Broulik
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141210/8f683432/attachment.html>
More information about the Plasma-devel
mailing list