Review Request 121365: Update brightness availability at runtime

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121365/#review71682
-----------------------------------------------------------

Ship it!


Looks good.


dataengines/powermanagement/powermanagementengine.cpp
<https://git.reviewboard.kde.org/r/121365/#comment49984>

    remove


- Sebastian Kügler


On Dec. 9, 2014, 6:25 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121365/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2014, 6:25 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This listens for maximum brightness changes to update the availability accordingly. It does not, however, monitor for the brightnesscontrols interface to become available on dbus and I have no idea how that would be done.
> 
> 
> Diffs
> -----
> 
>   dataengines/powermanagement/powermanagementengine.h 8088209 
>   dataengines/powermanagement/powermanagementengine.cpp ae10a0c 
> 
> Diff: https://git.reviewboard.kde.org/r/121365/diff/
> 
> 
> Testing
> -------
> 
> Works as before, cannot really test that since I cannot rip out my keyboard. Please see the other review.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141210/a2eedfc2/attachment.html>