Review Request 121417: Fix scaling progress bar and slider

Kai Uwe Broulik kde at privat.broulik.de
Tue Dec 9 21:47:20 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121417/
-----------------------------------------------------------

(Updated Dec. 9, 2014, 9:47 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma and Marco Martin.


Repository: plasma-framework


Description
-------

The progress bar is most likely a porting oversight when moving to the plasmastyle, the slider's thickness is now also fixed.


Diffs
-----

  src/declarativeimports/plasmastyle/ProgressBarStyle.qml 009e580 
  src/declarativeimports/plasmastyle/SliderStyle.qml aeedfcf 

Diff: https://git.reviewboard.kde.org/r/121417/diff/


Testing
-------

There's an issue with the slider's framesvg but that's unrelated to this patch - if you look closely on the Before screenshot you can see the corners folded inward too.


File Attachments
----------------

Before
  https://git.reviewboard.kde.org/media/uploaded/files/2014/12/09/8462eb8a-7ab5-40fd-b4d0-2c64c934b5c6__batterydevicepixelbefore.png
After (fixed)
  https://git.reviewboard.kde.org/media/uploaded/files/2014/12/09/839cdbaa-ce93-4ff2-8e09-4a0b04f2b0fc__batterydevicepixelafter1.png


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141209/f0e1b904/attachment.html>


More information about the Plasma-devel mailing list