Review Request 121402: Allow user to customise wallpaper used in the lock screen.
Martin Gräßlin
mgraesslin at kde.org
Tue Dec 9 15:23:16 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121402/#review71648
-----------------------------------------------------------
ksmserver/screenlocker/kcm/selectimagebutton.cpp
<https://git.reviewboard.kde.org/r/121402/#comment49961>
just a c++11 suggestion:
SelectImageButton::~SelectImageButton() = default;
ksmserver/screenlocker/kcm/selectimagebutton.cpp
<https://git.reviewboard.kde.org/r/121402/#comment49962>
coding style: { to new line
ksmserver/screenlocker/kcm/selectimagebutton.cpp
<https://git.reviewboard.kde.org/r/121402/#comment49963>
coding style
- Martin Gräßlin
On Dec. 9, 2014, 1:29 p.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121402/
> -----------------------------------------------------------
>
> (Updated Dec. 9, 2014, 1:29 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> Allow user to customise wallpaper used in the lock screen.
>
> Nothing very fancy it's the same plain image approach we use in SDDM.
> Default behaviour is unchanged. We can always expand it later.
>
>
> Diffs
> -----
>
> ksmserver/screenlocker/kcm/kcm.ui c891cc9
> ksmserver/screenlocker/kcm/selectimagebutton.h PRE-CREATION
> ksmserver/screenlocker/kcm/selectimagebutton.cpp PRE-CREATION
> lookandfeel/contents/lockscreen/LockScreen.qml ca9beb2
> ksmserver/screenlocker/greeter/greeterapp.cpp 60bd347
> ksmserver/screenlocker/kcfg/kscreenlockersettings.kcfg 5207615
> ksmserver/screenlocker/kcm/CMakeLists.txt a23a0fc
> ksmserver/screenlocker/kcm/kcm.cpp 0f74c45
>
> Diff: https://git.reviewboard.kde.org/r/121402/diff/
>
>
> Testing
> -------
>
> Opened lockscreen.
> Most code is tried and tested in the SDDM KCM.
>
>
> Thanks,
>
> David Edmundson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141209/10ee1b7e/attachment.html>
More information about the Plasma-devel
mailing list