Review Request 121396: fix touchpad scrolling on task manager
Kai Uwe Broulik
kde at privat.broulik.de
Tue Dec 9 10:29:46 UTC 2014
> On Dez. 9, 2014, 12:36 vorm., Aleix Pol Gonzalez wrote:
> > applets/taskmanager/package/contents/code/tools.js, line 22
> > <https://git.reviewboard.kde.org/r/121396/diff/1/?file=332296#file332296line22>
> >
> > so why don't you use the angleDelta?
>
> Xuetian Weng wrote:
> It's not WheelEvent produced by MouseArea. Task manager is still using MouseEventListener. I reference it for the 120 number.
>
> Aleix Pol Gonzalez wrote:
> How hard would it be to port the Task Manager?
MEL is from a time before Qt supported pixel-precise scrolling, so it only has delta. The pixelDelta/angleDelta split is relatively new in Qt as well, at least it only works on X11 since 5.3.
Task Manager does a lot of event interception and handling which aren't feasible with pure MouseArea, I guess. Eike should know best.
- Kai Uwe
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121396/#review71604
-----------------------------------------------------------
On Dez. 8, 2014, 9:44 nachm., Xuetian Weng wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121396/
> -----------------------------------------------------------
>
> (Updated Dez. 8, 2014, 9:44 nachm.)
>
>
> Review request for Plasma, Aleix Pol Gonzalez and Kai Uwe Broulik.
>
>
> Repository: plasma-desktop
>
>
> Description
> -------
>
> like https://git.reviewboard.kde.org/r/121346/
> Use delta value in wheel event for correct wheel handling.
>
>
> Diffs
> -----
>
> applets/taskmanager/package/contents/code/tools.js 163e741
> applets/taskmanager/package/contents/ui/MouseHandler.qml f7b2755
> applets/taskmanager/package/contents/ui/Task.qml e81411f
>
> Diff: https://git.reviewboard.kde.org/r/121396/diff/
>
>
> Testing
> -------
>
> scrolling with touchpad isn't out of control anymore :)
>
>
> Thanks,
>
> Xuetian Weng
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141209/fcf246e9/attachment-0001.html>
More information about the Plasma-devel
mailing list