Review Request 121384: Fix margins in systray

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121384/
-----------------------------------------------------------

(Updated Dec. 7, 2014, 9:20 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Repository: plasma-workspace


Description
-------

Now that the sidebar is hidden when item is not, stuff looks quite broken.


Diffs
-----

  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml c5c35bd 

Diff: https://git.reviewboard.kde.org/r/121384/diff/


Testing
-------

Looks much better, not sure whether the margin between the separtor and the Passive item is enough or like it was before, but looks okay.

One severe issue remains, though (outside this patch): The thing only checks the plasmoid's status, not whether it is forcefully hidden/shown by the tray which means: clicking a Passive plasmoid that is forced to be shown shows the sidebar and vice-versa clicking a hidden plasmoid that is Active hides the sidebar with no obvious way to get back to the list.


File Attachments
----------------

Tray overview
  https://git.reviewboard.kde.org/media/uploaded/files/2014/12/07/ea866377-7ccc-47cd-b1cc-b79954cb7bdb__tray_list.png
Active plasmoid
  https://git.reviewboard.kde.org/media/uploaded/files/2014/12/07/23ab78b4-5774-48e1-b639-acf4452263c7__tray_activeexpand.png
Passive plasmoid
  https://git.reviewboard.kde.org/media/uploaded/files/2014/12/07/ea8b8c05-4015-4dd0-b17a-3b4e6bc0a653__tray_hiddenexpand.png


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141207/e7abdbaa/attachment.html>