Review Request 121365: Update brightness availability at runtime

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121365/#review71499
-----------------------------------------------------------


+1 Looks good to me.

Maybe you want to include the Solid team in the discussion?

- Aleix Pol Gonzalez


On Dec. 6, 2014, 12:48 a.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121365/
> -----------------------------------------------------------
> 
> (Updated Dec. 6, 2014, 12:48 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This listens for maximum brightness changes to update the availability accordingly. It does not, however, monitor for the brightnesscontrols interface to become available on dbus and I have no idea how that would be done.
> 
> 
> Diffs
> -----
> 
>   dataengines/powermanagement/powermanagementengine.h 8088209 
>   dataengines/powermanagement/powermanagementengine.cpp a9020cf 
> 
> Diff: https://git.reviewboard.kde.org/r/121365/diff/
> 
> 
> Testing
> -------
> 
> Works as before, cannot really test that since I cannot rip out my keyboard. Please see the other review.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141207/dff8dd36/attachment.html>