Review Request 121357: Don't allow changing the volume when playing a notification

[Jeremy Whiting]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121357/#review71371
-----------------------------------------------------------

Ship it!


I agree.

- Jeremy Whiting


On Dec. 4, 2014, 2:23 p.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121357/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2014, 2:23 p.m.)
> 
> 
> Review request for Plasma and David Edmundson.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> Playing a notification is that, playing a notification. It is the user responsability to change the volume to their liking.
> 
> Suggested by David in https://git.reviewboard.kde.org/r/121278/
> 
> Goes hand in hand with https://git.reviewboard.kde.org/r/121356/
> 
> 
> Diffs
> -----
> 
>   kcms/knotify/playersettings.ui 54bb627 
>   kcms/knotify/knotify.cpp b05c011 
> 
> Diff: https://git.reviewboard.kde.org/r/121357/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141204/727d6f60/attachment.html>