Review Request 121355: Expose actual and maximum brightness value in dataengine

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121355/
-----------------------------------------------------------

Review request for Plasma and Solid.


Repository: plasma-workspace


Description
-------

Now that we can finally use absolute brightness values, rather than a fixed 0-100% range, those values should be exposed in the dataengine instead. This allows us to eg. properly handle keyboard brightness controls which usually have just a few steps. I adjusted battery monitor accordingly.

It also cleans up the code by moving stuff into lambdas and gets rid of the ugly availability stuff by just relying on the maximum values to determin whether it's available. We still don't have means, though, to detect changes in these at runtime.


Diffs
-----

  dataengines/powermanagement/powermanagementengine.h ffad13e 
  dataengines/powermanagement/powermanagementengine.cpp 04aa49b 
  dataengines/powermanagement/powermanagementjob.cpp c4e4510 

Diff: https://git.reviewboard.kde.org/r/121355/diff/


Testing
-------

Works as expected, I need someone without keyboard or screen brightness to test the availability.


File Attachments
----------------

Battery monitor with keyboard
  https://git.reviewboard.kde.org/media/uploaded/files/2014/12/04/c00db2e1-5278-4a1b-bd32-ff36777b91c6__batterykeyboardsteps.png


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141204/9f32e777/attachment.html>