Review Request 121333: Fix lockscreen theme fallback

Kai Uwe Broulik kde at privat.broulik.de
Tue Dec 2 22:10:51 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121333/
-----------------------------------------------------------

Review request for Plasma and Martin Gräßlin.


Repository: plasma-workspace


Description
-------

When the look and feel lockscreen theme failed to load for whatever reason, it is supposed to fall back to a built-in theme to not lock the user out of the system.

The fallbak did not work and crashed with an invalid package access, trapping you in an endless kscreenlocker_greet reboot loop. This is most likely a porting oversight since the default lockscreen theme, as indicated by the constant, is no longer present or used.


Diffs
-----

  ksmserver/screenlocker/greeter/greeterapp.cpp d3f9f28 

Diff: https://git.reviewboard.kde.org/r/121333/diff/


Testing
-------

Messed around in the look and feel qml file, got fallback.

The fallback theme is quite broken, though, with the switch user button not working, the dialog background missing as well as the wallpaper but at leas it now works again.


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141202/f7759bf7/attachment.html>


More information about the Plasma-devel mailing list