Change in plasma-framework[master]: fix typo height -> width

Xuetian Weng (Code Review) noreply at kde.org
Tue Dec 2 15:02:31 UTC 2014


Xuetian Weng has uploaded a new change for review.

  https://gerrit.vesnicky.cesnet.cz/r/196

Change subject: fix typo height -> width
......................................................................

fix typo height -> width

updateMinimumWidth and updateMaximumWidth wrongly set the updated
value to height instead of width.

Change-Id: Ie24ef194d9bf02e53b92aa6802b0fbded68b896d
---
M src/plasmaquick/dialog.cpp
1 file changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.vesnicky.cesnet.cz:29418/plasma-framework refs/changes/96/196/1

diff --git a/src/plasmaquick/dialog.cpp b/src/plasmaquick/dialog.cpp
index 931068a..1c07ab0 100644
--- a/src/plasmaquick/dialog.cpp
+++ b/src/plasmaquick/dialog.cpp
@@ -326,8 +326,8 @@
     //on the scene
     auto margin = frameSvgItem->fixedMargins();
     int minimumWidth = mainItemLayout->property("minimumWidth").toInt() + margin->left() + margin->right();
-    q->contentItem()->setHeight(qMax(q->width(), minimumWidth));
-    q->setHeight(qMax(q->width(), minimumWidth));
+    q->contentItem()->setWidth(qMax(q->width(), minimumWidth));
+    q->setWidth(qMax(q->width(), minimumWidth));
 
     hintsCommitTimer.start();
 }
@@ -368,8 +368,8 @@
 
     auto margin = frameSvgItem->fixedMargins();
     int maximumWidth = mainItemLayout->property("maximumWidth").toInt() + margin->left() + margin->right();
-    q->contentItem()->setHeight(qMax(q->width(), maximumWidth));
-    q->setHeight(qMax(q->width(), maximumWidth));
+    q->contentItem()->setWidth(qMax(q->width(), maximumWidth));
+    q->setWidth(qMax(q->width(), maximumWidth));
 
     hintsCommitTimer.start();
 }

-- 
To view, visit https://gerrit.vesnicky.cesnet.cz/r/196
To unsubscribe, visit https://gerrit.vesnicky.cesnet.cz/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie24ef194d9bf02e53b92aa6802b0fbded68b896d
Gerrit-PatchSet: 1
Gerrit-Project: plasma-framework
Gerrit-Branch: master
Gerrit-Owner: Xuetian Weng <wengxt at gmail.com>
Gerrit-Reviewer: Marco Martin <notmart at gmail.com>


More information about the Plasma-devel mailing list