Review Request 121311: Remove mnemonic underlines when alt-tabbing

Martin Gräßlin mgraesslin at kde.org
Mon Dec 1 14:48:25 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121311/#review71189
-----------------------------------------------------------


this is not a sufficient solution (I fear). Scnario:
1. go to application and press Alt
2. move mouse to trigger Present Windows effect
3. release alt key
4. activate same application again

=> will still be underlined as the application state never changed, but the application never got the key release event.

The root problem here is not that the active application changes, but that another process grabs the X11 keyboard. What would be needed is to detect that the keyboard is grabbed. Otherwise it will fail with any such setups where a keyboard grab is involved.

- Martin Gräßlin


On Dec. 1, 2014, 3:42 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121311/
> -----------------------------------------------------------
> 
> (Updated Dec. 1, 2014, 3:42 p.m.)
> 
> 
> Review request for Plasma and Hugo Pereira Da Costa.
> 
> 
> Repository: breeze
> 
> 
> Description
> -------
> 
> Remove mnemonic underlines when alt-tabbing
> 
> Alt+tab messes with the nmemonics.
> In Qt5 we get a keyPressEvent, then we lose focus and don't receive a
> keyReleaseEvent
> 
> This means the application keeps showing the mnemonic helpers even when
> we switch back to the application.
> 
> BUG: 341006
> 
> 
> Diffs
> -----
> 
>   kstyle/breezemnemonics.cpp 9395ea9 
> 
> Diff: https://git.reviewboard.kde.org/r/121311/diff/
> 
> 
> Testing
> -------
> 
> Ran dolphin, pressed alt+tab a lot. Even with multiple windows it seems OK.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141201/e494bf7c/attachment.html>


More information about the Plasma-devel mailing list