Review Request 119993: Port KAuth actions in libksysguard

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119993/#review65523
-----------------------------------------------------------

Ship it!


Looks good. Minor comments


processcore/helper.cpp
<https://git.reviewboard.kde.org/r/119993/#comment45779>

    why not just use the right enum value?



processui/ksysguardprocesslist.cpp
<https://git.reviewboard.kde.org/r/119993/#comment45780>

    There should be pretty headers


- David Edmundson


On Aug. 29, 2014, 4:12 p.m., Hrvoje Senjan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119993/
> -----------------------------------------------------------
> 
> (Updated Aug. 29, 2014, 4:12 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: libksysguard
> 
> 
> Description
> -------
> 
> that was one (vital imho ;-) feature missing compared to 4.x
> 
> 
> Diffs
> -----
> 
>   processui/ksysguardprocesslist.cpp 1651a0a 
>   processcore/CMakeLists.txt 31eee10 
>   processcore/helper.cpp 6c1f570 
>   processcore/processes_linux_p.cpp 65b8dfd 
> 
> Diff: https://git.reviewboard.kde.org/r/119993/diff/
> 
> 
> Testing
> -------
> 
> ioscheduler, cpuscheduler, sendsignal, renice actions all work.
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140829/83bce415/attachment.html>