Review Request 119984: more plasmashell code cleaning

Martin Klapetek martin.klapetek at gmail.com
Fri Aug 29 09:49:58 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119984/#review65470
-----------------------------------------------------------



shell/shellcorona.cpp
<https://git.reviewboard.kde.org/r/119984/#comment45734>

    KScreen::Output* ShellCorona -> KScreen::Output *ShellCorona
    
    (or the other way around and then fix the two methods above



shell/shellcorona.cpp
<https://git.reviewboard.kde.org/r/119984/#comment45733>

    KScreen::Output* output -> KScreen::Output *output


- Martin Klapetek


On Aug. 29, 2014, 9:43 a.m., Aaron J. Seigo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119984/
> -----------------------------------------------------------
> 
> (Updated Aug. 29, 2014, 9:43 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Three commits that clean up some code warts in plasmashell.
> 
> 
> Diffs
> -----
> 
>   shell/main.cpp bb63bdc85ff2a003fa4a5c4e2320383db98da087 
>   shell/shellcorona.h d559fcdc99c0066d552e013d3fea249147f50b5f 
>   shell/shellcorona.cpp 84442ae60cf0f576a077e770ceae82a17721a456 
> 
> Diff: https://git.reviewboard.kde.org/r/119984/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aaron J. Seigo
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140829/068fa6ac/attachment.html>


More information about the Plasma-devel mailing list