Review Request 119967: Fix systemloadviewer monitorType settings

David Edmundson david at davidedmundson.co.uk
Thu Aug 28 12:03:37 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119967/#review65420
-----------------------------------------------------------

Ship it!


Ship It!

- David Edmundson


On Aug. 28, 2014, 8:23 a.m., Martin Yrjölä wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119967/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2014, 8:23 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> -------
> 
> Fix systemloadviewer monitorType settings
> 
> The third revision of the port broke the changing of monitor type through settings, it slipped past me because the setting worked when restarting plasmashell.
> 
> 
> Diffs
> -----
> 
>   applets/systemloadviewer/package/contents/ui/ConditionallyLoadedMonitors.qml 403c01cb93d350e341babb6830277eedd7f06a6c 
> 
> Diff: https://git.reviewboard.kde.org/r/119967/diff/
> 
> 
> Testing
> -------
> 
> Changing between Bar and Circular monitor types in the plasmoid settings works now as expected.
> 
> 
> Thanks,
> 
> Martin Yrjölä
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140828/f2a7f482/attachment.html>


More information about the Plasma-devel mailing list