Review Request 119966: add an InteractiveConsole.qml
Marco Martin
notmart at gmail.com
Thu Aug 28 08:58:21 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119966/#review65401
-----------------------------------------------------------
Ship it!
Ship it! (after 119965)
- Marco Martin
On Aug. 28, 2014, 8:19 a.m., Aaron J. Seigo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119966/
> -----------------------------------------------------------
>
> (Updated Aug. 28, 2014, 8:19 a.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-desktop
>
>
> Description
> -------
>
> This adds an InteractiveConsole.qml file to go along with Review Request #119965. The main discussion point is what the name of the QML file should be and its location in the shell package. I have no particular opinion one way or the other, so I'll be looking to whoever maintains that particular design to say either "that's fine where it is in the patch" or give a different location that I will move it to.
>
>
> Diffs
> -----
>
> desktoppackage/contents/InteractiveConsole.qml PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/119966/diff/
>
>
> Testing
> -------
>
> Tested in plasmashell.
>
>
> Thanks,
>
> Aaron J. Seigo
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140828/2f41ed03/attachment.html>
More information about the Plasma-devel
mailing list