Review Request 118406: Notify the user if the location containing the media is inaccessible.

R.Harish Navnit harishnavnit at gmail.com
Tue Aug 26 21:01:17 UTC 2014



> On Aug. 26, 2014, 5:35 p.m., Sinny Kumari wrote:
> > I am assunimg that you will do remaining error handling fix in next patch like codec missing, inaccessible media played from media browser

Yes, next patch should fix all those. Can this change be comitted on my behalf ? 
Thanks.


- R.Harish


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118406/#review65292
-----------------------------------------------------------


On Aug. 24, 2014, 1:14 p.m., R.Harish  Navnit wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118406/
> -----------------------------------------------------------
> 
> (Updated Aug. 24, 2014, 1:14 p.m.)
> 
> 
> Review request for Plasma, Shantanu Tushar and Sinny Kumari.
> 
> 
> Bugs: 333764
>     http://bugs.kde.org/show_bug.cgi?id=333764
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> -------
> 
> If a media(in a playlist) is located in an inaccessible location, then the user is notified about the same. 
> 
> 
> Diffs
> -----
> 
>   mediaelements/mediaplayer/MediaPlayer.qml 98f1d2c733e272ad9941264b99f25fd952edcbec 
>   shells/newshell/package/contents/ui/mediacenter.qml 394f820445b2b6896f6540a5d35cb55edfb2f139 
> 
> Diff: https://git.reviewboard.kde.org/r/118406/diff/
> 
> 
> Testing
> -------
> 
> 1. Load media to a playlist.
> 2. Unmount the device containing media.
> 3. Check if the user is notified of the location being inaccessible
>    --yes, the user is notified
> 4. Mount the device containing media and play a media from playlist.
>    -- The media plays properly.
> 
> 
> File Attachments
> ----------------
> 
> wihtout_i18n.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/06/05/3dc148a5-c4da-4d27-a713-e63922cbcef8__wihtout_i18n.png
> 
> 
> Thanks,
> 
> R.Harish  Navnit
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140826/a2e44e47/attachment.html>


More information about the Plasma-devel mailing list