Review Request 119946: Wrap the desktop alternatives UI in a dialog

[Aaron J. Seigo]

> On Aug. 26, 2014, 5:53 p.m., Marco Martin wrote:
> > desktoppackage/contents/explorer/AppletAlternatives.qml, line 41
> > <https://git.reviewboard.kde.org/r/119946/diff/1/?file=307712#file307712line41>
> >
> >     omg, tabs? :p

I'm not seeing any tabs there in the diff. The arrows just mean that the line didn't change, but whitespace was added. Nifty feature of r-b if you ask me; makes the diff visually a lot less noisy while still showing ws changes.


- Aaron J.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119946/#review65295
-----------------------------------------------------------


On Aug. 26, 2014, 7:39 p.m., Aaron J. Seigo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119946/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2014, 7:39 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> Following up on the changes to plasmashell, the dialog needs to used from the QML in the shell package.
> 
> 
> Diffs
> -----
> 
>   desktoppackage/contents/explorer/AppletAlternatives.qml de99b1ca370c819687230c1bcd54d2839b08dab9 
> 
> Diff: https://git.reviewboard.kde.org/r/119946/diff/
> 
> 
> Testing
> -------
> 
> Used Plasma Desktop with this shell package.
> 
> 
> Thanks,
> 
> Aaron J. Seigo
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140826/a9c3954f/attachment.html>